Java 6173 - #2042
Draft
strogiyotec wants to merge 3 commits into
Draft
Conversation
strogiyotec
commented
Aug 20, 2026
| * The settings for reaching a destination through a proxy server. | ||
| * | ||
| * <p>These settings are applied in two independent places, which support different | ||
| * {@linkplain ProxyProtocol protocols}:</p> |
Contributor
Author
There was a problem hiding this comment.
the name of this class is ProxySetting though it was only used as a socks5 proxy to mongo server
Instead of duplicating similar logic I introduced an inner protocol which defaults to socks5 so that existing code base won't have to be changed, but kms proxy can change protocol to https
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.