Skip to content

Remove skip for GridFS download timeout test #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vbabanin wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove skip for GridFS download timeout test #1912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4989d13
Remove skip for GridFS download timeout test
vbabanin Mar 15, 2026
a825ae1
Merge branch 'main' into JAVA-5839
vbabanin Mar 15, 2026
d660f87
Make submodule to use fork.
vbabanin Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "specifications"]
path = testing/resources/specifications
url = https://github.com/mongodb/specifications
url = https://github.com/vbabanin/specifications
Comment on lines 1 to +3
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule URL was changed from the official mongodb/specifications repo to a personal fork (vbabanin/specifications). This is a significant behavioral/supply-chain change and does not align with the PR goal (unskipping a test). Please revert the URL back to the official upstream (or whatever canonical URL this repo expects) so CI and local checkouts use the intended specifications source.

Copilot uses AI. Check for mistakes.
4 changes: 0 additions & 4 deletions driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,6 @@ public static void applyCustomizations(final TestDef def) {
.test("client-side-operations-timeout", "timeoutMS behaves correctly for tailable awaitData cursors",
"apply maxAwaitTimeMS if less than remaining timeout");

def.skipJira("https://jira.mongodb.org/browse/JAVA-5839")
.test("client-side-operations-timeout", "timeoutMS behaves correctly for GridFS download operations",
"timeoutMS applied to entire download, not individual parts");

def.skipJira("https://jira.mongodb.org/browse/JAVA-5491")
.when(() -> !serverVersionLessThan(8, 3))
.test("client-side-operations-timeout", "operations ignore deprecated timeout options if timeoutMS is set",
Expand Down
2 changes: 1 addition & 1 deletion testing/resources/specifications
Open in desktop
Submodule specifications updated 127 files