Skip to content

Make NettyByteBuf share parent reference count. #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbabanin merged 5 commits into from
Feb 20, 2026
Merged

Make NettyByteBuf share parent reference count. #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb96889
Make NettyByteBuf share parent reference count.
vbabanin Feb 18, 2026
eb83914
Use readSlice().retain().
vbabanin Feb 19, 2026
4e8b5f9
Update driver-core/src/main/com/mongodb/internal/connection/netty/Net…
vbabanin Feb 19, 2026
500b463
Enable tests.
vbabanin Feb 19, 2026
6f00611
Fix static checks.
vbabanin Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion driver-core/src/main/com/mongodb/internal/connection/netty/NettyByteBuf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ public ByteBuf asReadOnly() {

@Override
public ByteBuf duplicate() {
return new NettyByteBuf(proxied.retainedDuplicate(), isWriting);
return new NettyByteBuf(proxied.duplicate().retain(), isWriting);
}

@Override
Expand Down
3 changes: 2 additions & 1 deletion driver-core/src/main/com/mongodb/internal/connection/netty/NettyStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ private void readAsync(final int numBytes, final AsyncCompletionHandler<ByteBuf>
composite.addComponent(next);
iter.remove();
} else {
composite.addComponent(next.readRetainedSlice(bytesNeededFromCurrentBuffer));
next.retain();
composite.addComponent(next.readSlice(bytesNeededFromCurrentBuffer));
}
composite.writerIndex(composite.writerIndex() + bytesNeededFromCurrentBuffer);
bytesNeeded -= bytesNeededFromCurrentBuffer;
Expand Down
3 changes: 0 additions & 3 deletions ...ore/src/test/functional/com/mongodb/internal/connection/CommandHelperSpecification.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import com.mongodb.connection.SocketSettings
import com.mongodb.internal.connection.netty.NettyStreamFactory
import org.bson.BsonDocument
import org.bson.BsonInt32
import spock.lang.Ignore
import spock.lang.Specification

import java.util.concurrent.CountDownLatch
Expand Down Expand Up @@ -57,7 +56,6 @@ class CommandHelperSpecification extends Specification {
connection?.close()
}

@Ignore("JAVA-5982")
def 'should execute command asynchronously'() {
when:
BsonDocument receivedDocument = null
Expand All @@ -84,5 +82,4 @@ class CommandHelperSpecification extends Specification {
!receivedDocument
receivedException instanceof MongoCommandException
}

}