Fix release notes diff in github release actions#1882
Fix release notes diff in github release actions#1882atandon2024 wants to merge 1 commit intomongodb:mainfrom
Conversation
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
One question about fetch depth.
| with: | ||
| app_id: ${{ vars.APP_ID }} | ||
| private_key: ${{ secrets.APP_PRIVATE_KEY }} | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
What does this do?
I think fetch-depth: 0 fetches all history for all branches and tags. But is it just for the mongodb-labs/drivers-github-tools/secure-checkout or is it for the java driver repo itself?
There was a problem hiding this comment.
@rozza yes fetch-depth 0 fetches all branches and tags.
Per the GitHub Actions documentation (https://docs.github.com/en/actions/tutorials/create-an-example-workflow), drivers-github-tools is only pulled internally to run the action itself. The checkout operates on github.ref.
There was a problem hiding this comment.
Have we tested this in the fork yet? I also noticed the note: "Needs to be tested by triggering GitHub Actions manually before merging.”
atandon2024
force-pushed
the
fix-github-release-notes
branch
from
1f0c2bf to
f4ec15e
Compare
3 participants
Fix GitHub Actions release notes generation - Corrects an issue where draft release notes included commits from earlier releases due to an incorrect comparison range.
Needs to be tested by triggering Github Actions manually before merging.