Skip to content

MONGOCRYPT-886 Remove link to mongodb enteprise repo fork in comments#1132

Merged
kevinAlbs merged 2 commits intomongodb:masterfrom
erwee:erwee/MONGOCRYPT-886
Feb 24, 2026
Merged

MONGOCRYPT-886 Remove link to mongodb enteprise repo fork in comments#1132
kevinAlbs merged 2 commits intomongodb:masterfrom
erwee:erwee/MONGOCRYPT-886

Conversation

@erwee
Copy link
Collaborator

@erwee erwee commented Feb 24, 2026

No description provided.

@erwee erwee requested a review from kevinAlbs February 24, 2026 14:33
@erwee erwee requested a review from a team as a code owner February 24, 2026 14:33
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM with a link fix.

* FLE2 Blob Subtypes are currently defined in:
* https://github.com/markbenvenuto/mongo-enterprise-modules/blob/fle2/fle_protocol.md#reference-bindata-6-subtypes.
* These are defined by the EncryptedBinDataType enum in:
* https://github.com/mongodb/mongo/blob/2f4ed6f765c1ba6b3e857d06e91842e6065eb87b/src/mongo/crypto/fle_field_schema.idl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update link? I get a 404 on the current link.

Suggested change
* https://github.com/mongodb/mongo/blob/2f4ed6f765c1ba6b3e857d06e91842e6065eb87b/src/mongo/crypto/fle_field_schema.idl
* https://github.com/mongodb/mongo/blob/0d51c5cb6571a14e690c4774bb069d1990fd35b6/src/mongo/crypto/fle_field_schema.idl

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@kevinAlbs kevinAlbs merged commit caa6bb7 into mongodb:master Feb 24, 2026
8 of 9 checks passed
@erwee erwee deleted the erwee/MONGOCRYPT-886 branch February 24, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants