Skip to content

deps: allow coincurve 21 to fix Python 3.13 source build#35

Merged
pdobacz merged 1 commit into
forks/monad_ninefrom
fix-coincurve
Jul 8, 2026
Merged

deps: allow coincurve 21 to fix Python 3.13 source build#35
pdobacz merged 1 commit into
forks/monad_ninefrom
fix-coincurve

Conversation

@pdobacz

@pdobacz pdobacz commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This PR allows the project to use coincurve 21.x. The main changes are:

  • Widened the root coincurve dependency range to <22.
  • Widened the testing package coincurve dependency range to <22.
  • Updated the lockfile to coincurve 21.0.0 and removed its old transitive asn1crypto entry.
  • Inlined the secp256k1_recover public-key formatting return.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
pyproject.toml Widens the main package coincurve dependency range from <21 to <22.
packages/testing/pyproject.toml Widens the testing package coincurve dependency range from <21 to <22.
src/ethereum/crypto/elliptic_curve.py Returns the formatted uncompressed public key directly from secp256k1_recover.
uv.lock Locks coincurve to 21.0.0 and updates dependency metadata.

Reviews (1): Last reviewed commit: "deps: allow coincurve 21 to fix Python 3..." | Re-trigger Greptile

coincurve 20 has no cp313 wheel; scikit-build-core 1.0.0 (2026-07-06) turned its cmake.verbose deprecation into a hard error, breaking the from-source build.

Co-Authored-By: Claude <claude-opus-4-8>
@pdobacz pdobacz requested review from QEDK and mijovic as code owners July 8, 2026 16:37
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcoincurve@​20.0.0 ⏵ 21.0.0100100100100100

View full report

@pdobacz pdobacz merged commit 493cf4b into forks/monad_nine Jul 8, 2026
7 checks passed
@pdobacz pdobacz deleted the fix-coincurve branch July 8, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants