fix(api): omit customer secrets from profile/add responses#428
Open
Ibochkarev wants to merge 1 commit into
Open
fix(api): omit customer secrets from profile/add responses#428Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Web API returned password hash and msCustomer.token via toArray(). Use an allowlisted public DTO for PUT profile and POST add.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
PUT /api/v1/customer/profileиPOST /api/v1/customer/addотдавали$customer->toArray()целиком: в JSON попадалиpassword(hash) иmsCustomer.token. После путей checkout, где token может совпадать с API-токеном (#369), это даёт захват сессии.Добавлен
CustomerPublicDtoс allowlist публичных полей (fail-closed). Оба success-ответа профиля сериализуют клиента через него.Тип изменений
Ответ
data.customerбольше не содержит секреты и lock/privacy-поля (password,token,privacy_ip,failed_login_attempts,blocked_until,is_blocked,user_id). Клиенты, которые читали эти ключи из profile/add, нужно обновить. Новые колонки модели (в т.ч. OE) в публичный payload не попадают, пока их явно не добавят в allowlist.Связанные Issues
Closes #410
Как это было протестировано?
Gate E:
php -lнаCustomerPublicDto.php,CustomerProfileController.php,CustomerPublicDtoTest.php→ exit 0php core/components/minishop3/tests/CustomerPublicDtoTest.php→ exit 0 (OK CustomerPublicDtoTest)Конфигурация тестирования:
fix/issue-410-customer-profile-secretsСкриншоты (если применимо)
Чеклист
Дополнительные заметки
ProfilePageService, legacyCustomer::getFields()и другиеtoArray()— отдельные поверхности ([Bug] Web API: profile/add отдаёт password hash и msCustomer.token в JSON #410 только profile/add JSON).