Skip to content

Fix main CI compatibility and release token checks #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nsttt merged 1 commit into from
Oct 14, 2026
Merged

Fix main CI compatibility and release token checks #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["22.18.0", "24", "26"]
node: ["24", "26"]
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0
Expand Down
25 changes: 0 additions & 25 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions test/release-contracts.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ test("CI uses Node versions supported by the package build toolchain", () => {
const supportedNode = "^22.18.0 || ^24.11.0 || >=26.0.0";
assert.equal(rootPackageJson.engines.node, supportedNode);
assert.equal(packageJson.engines.node, supportedNode);
assert.match(ciWorkflow, /node: \["22\.18\.0", "24", "26"\]/);
assert.match(ciWorkflow, /node: \["24", "26"\]/);
assert.doesNotMatch(ciWorkflow, /22\.12\.0/);
});

Expand Down Expand Up @@ -718,8 +718,9 @@ test("release-please output passes the format gate in release PRs and publishes"
});

test("release-please releases trigger the trusted publish workflow", () => {
// Releases created with GITHUB_TOKEN do not start other workflows.
assert.match(releasePleaseWorkflow, /token: \$\{\{ secrets\.REPO_SCOPED_TOKEN \}\}/);
// Releases created with GITHUB_TOKEN do not start other workflows, so release-please uses an app token.
assert.match(releasePleaseWorkflow, /uses: actions\/create-github-app-token@/);
assert.match(releasePleaseWorkflow, /token: \$\{\{ steps\.app-token\.outputs\.token \}\}/);
assert.match(releaseWorkflow, /release:\n\s+types: \[published\]/);
assert.doesNotMatch(releaseWorkflow, /changeset/i);
assert.equal(existsSync(join(root, ".changeset")), false);
Expand Down
Loading