Skip to content

fix(Combobox): Chevron interactivity - #7975

Merged
mergify[bot] merged 1 commit into
modrinth:mainfrom
logiczsniper:lczernel/combobox-chevron-pointer-events
Oct 22, 2026
Merged

mergify[bot] merged 1 commit into
modrinth:mainfrom
logiczsniper:lczernel/combobox-chevron-pointer-events

Conversation

@logiczsniper

Copy link
Copy Markdown
Contributor

Fixes #7927

  • Changes cursor when hovering over chevron
  • Prevents mousedown events to prevent the handleSearchFocusout handler from executing, which would cause another bug wherein clicking the chevron to close the dropdown would cause it to close (due to handleSearchFocusout) and then immediately re-open as the new handleSearchIconClick is called
  • Added handleSearchIconClick handler to enable opening and closing on click of the chevron

Note

This is my first PR in this repo - my first PR writing Vue in years 😅 and I don't see any test files... please lemme know if you wanna see anything else here 🙌

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@tdgao

tdgao commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@Mergifyio queue

@mergify

mergify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 5 minutes 47 seconds in the queue, including 5 minutes 9 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Oct 22, 2026
@mergify mergify Bot mentioned this pull request Oct 22, 2026
6 of 10 tasks
@mergify
mergify Bot merged commit a6ac434 into modrinth:main Oct 22, 2026
15 checks passed
@mergify mergify Bot removed the queued label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Version dropdown arrow icon is not clickable

2 participants