feat: Lock Provider Abstraction - #4
Draft
stephenwhittle wants to merge 11 commits into
Draft
stephenwhittle wants to merge 11 commits into
stephenwhittle wants to merge 11 commits into
Conversation
…ol as volatile; correctly deserialize lock objects from the HTTP API
kriNon
reviewed
Sep 11, 2026
| TArray<FString>& OutResults, TArray<FString>& OutErrorMessages) | ||
| { | ||
| auto Result = PerformHttpRequest(LockFileRequest(FGitSourceControlModule::Get().GetProvider().GetLockUser(), | ||
| Params.FileNames[0], FApp::GetProjectName())); |
There was a problem hiding this comment.
Would multi-file lock operations silently only lock FileNames[0] here? (same with UnlockFiles)
Collaborator
Author
There was a problem hiding this comment.
Just to quickly confirm @stephenwhittle Would we prefer to update conbot to also support batching and keep the api similar on the uegitplugin side? Or remove batching on the uegitplugin side and loop over each file, doing individual requests?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements an abstraction over locking functionality so we can use our internal lock server without having to deal with LFS.
Sitting in draft pending testing.
Clickup link: https://app.clickup.com/t/9003015469/GSCPP-2841