chore(ruff): converge on the standard's ruff block - #483
Merged
Conversation
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 1511a2e | Previous: e155700 | Ratio |
|---|---|---|---|
benchmarks/test_guard_by_type.py::test_g16_resolve_by_type |
4618622.340714271 iter/sec (stddev: 1.7330113272947066e-8) |
4174854.077472497 iter/sec (stddev: 1.100243717758211e-8) |
0.90 |
benchmarks/test_guard_by_type.py::test_g17_resolve_by_type_large_registry |
4644879.025509824 iter/sec (stddev: 6.620999592752358e-9) |
3965541.0346406153 iter/sec (stddev: 1.1047675751330486e-8) |
0.85 |
benchmarks/test_guard_cold.py::test_g8_cold_first_resolve |
17496.1386951957 iter/sec (stddev: 0.000051579470819626526) |
15999.801987269744 iter/sec (stddev: 0.00005532652498996289) |
0.91 |
benchmarks/test_guard_cold.py::test_g8b_cold_first_resolve_cached |
14754.15870655699 iter/sec (stddev: 0.0001201600673145632) |
13707.861334838028 iter/sec (stddev: 0.00011408439772956196) |
0.93 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[1] |
568.0419462173409 iter/sec (stddev: 0.00006211049620025357) |
561.7475817021748 iter/sec (stddev: 0.00007512889043850553) |
0.99 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[2] |
526.4172685482288 iter/sec (stddev: 0.00005861466293564149) |
521.4745912235675 iter/sec (stddev: 0.00011662153372139762) |
0.99 |
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[4] |
474.8735667313327 iter/sec (stddev: 0.0002090047515519692) |
465.41947851660495 iter/sec (stddev: 0.000029553405566414084) |
0.98 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[1] |
1909.4338347296 iter/sec (stddev: 0.00014933287785715861) |
1687.4269634161626 iter/sec (stddev: 0.00020156544423703462) |
0.88 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[2] |
1525.248680675068 iter/sec (stddev: 0.00016942380878659356) |
1331.1260896295373 iter/sec (stddev: 0.0002320671725634425) |
0.87 |
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[4] |
1138.9833303811802 iter/sec (stddev: 0.00018393022926888899) |
953.3181776417844 iter/sec (stddev: 0.0002878535200939029) |
0.84 |
benchmarks/test_guard_lifecycle.py::test_g6_build_child_container |
753634.7048170676 iter/sec (stddev: 3.110277998308862e-8) |
724503.8054513271 iter/sec (stddev: 4.411529762318937e-8) |
0.96 |
benchmarks/test_guard_lifecycle.py::test_g6b_build_child_container_auto_scope |
691975.9404117517 iter/sec (stddev: 1.7734497165035516e-7) |
666175.1515350264 iter/sec (stddev: 5.480035908934553e-8) |
0.96 |
benchmarks/test_guard_lifecycle.py::test_g7_request_lifecycle_batch |
2782.3169588375836 iter/sec (stddev: 0.000005898791162132502) |
2405.5322607698945 iter/sec (stddev: 0.000020758417839976964) |
0.86 |
benchmarks/test_guard_lifecycle.py::test_g7c_event_loop_floor_control |
74413.94772225256 iter/sec (stddev: 0.000001036331479176543) |
60380.985948720125 iter/sec (stddev: 0.0000018764998349171118) |
0.81 |
benchmarks/test_guard_lifecycle.py::test_g13_teardown_at_scale |
53786.59224326054 iter/sec (stddev: 0.0000013058138867252508) |
48795.33204266832 iter/sec (stddev: 0.000001994701552550599) |
0.91 |
benchmarks/test_guard_resolve.py::test_g1_transient_resolve |
2442417.56351889 iter/sec (stddev: 3.390662090083017e-8) |
2507735.1089434647 iter/sec (stddev: 2.5594136903833773e-8) |
1.03 |
benchmarks/test_guard_resolve.py::test_g2_cached_resolve |
4468129.3028481165 iter/sec (stddev: 5.5211117474829245e-9) |
4255460.393959906 iter/sec (stddev: 6.6218218703302085e-9) |
0.95 |
benchmarks/test_guard_resolve.py::test_g3_deep_chain |
863858.4744104866 iter/sec (stddev: 3.9368202399032533e-8) |
843381.8414294868 iter/sec (stddev: 5.837631681481394e-8) |
0.98 |
benchmarks/test_guard_resolve.py::test_g4_wide_resolve |
549747.4734974982 iter/sec (stddev: 2.8796065169763955e-7) |
511853.7392224613 iter/sec (stddev: 3.919091447867964e-7) |
0.93 |
benchmarks/test_guard_resolve.py::test_g5_cross_scope |
2010440.0139440906 iter/sec (stddev: 1.7988606370411174e-8) |
1903543.636752833 iter/sec (stddev: 3.274663774030733e-8) |
0.95 |
benchmarks/test_guard_resolve.py::test_g9_context_resolve |
1138828.9097766883 iter/sec (stddev: 1.3467784213975757e-7) |
1115022.0820383893 iter/sec (stddev: 1.5637904201077603e-7) |
0.98 |
benchmarks/test_guard_resolve.py::test_g12_override_active_resolve |
862934.9504953101 iter/sec (stddev: 2.3088455145828436e-8) |
840071.0179106364 iter/sec (stddev: 4.3323040570763156e-8) |
0.97 |
benchmarks/test_guard_resolve.py::test_g18_alias_hop |
3037328.924341567 iter/sec (stddev: 6.889117072742209e-8) |
2883027.5017899433 iter/sec (stddev: 1.0017859520930858e-8) |
0.95 |
benchmarks/test_guard_validate.py::test_g10_validate_deep_chain |
24620.33676256703 iter/sec (stddev: 0.00003096228991542621) |
24070.5998395637 iter/sec (stddev: 0.000025781481391703466) |
0.98 |
benchmarks/test_guard_validate.py::test_g11_validate_wide |
14687.638937422611 iter/sec (stddev: 0.0002416705873574518) |
15098.816925097415 iter/sec (stddev: 0.00002675492831143962) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
lesnik512
force-pushed
the
ruff-block
branch
from
September 12, 2026 11:09
fa87b75 to
1511a2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converges
[tool.ruff]on the block in the modern-python standard. Configuration only; no behaviour change in the package.Changes
fix = true, andtarget-versionremoved: ruff derives it fromrequires-python.The
ignorelist is the standard's eight entries, each with its one-line reason. Ignores measured to suppress nothing across the org are gone (G004,TRY003,EM102where present). Repo-specific ignores the standard allows are kept, with a reason.S101moves from a global ignore to"tests/**": assert is the test idiom, and in library code it is a finding. There were no package-side hits to fix.benchmarks/**gainsS101per-file: the guard-tier benchmarks are pytest tests that assert on ratios.Checklist
just lint-ci)ty, part oflint-ci)