docs: dedupe ResponseTooLargeError + respx rationale, fix httpx2 claim#105
Merged
Conversation
ResponseTooLargeError's behavior was spelled out near-verbatim in docs/errors.md, architecture/errors.md, and architecture/client.md; architecture/errors.md now cross-references the other two instead of restating them. The "why not respx" paragraph was duplicated between docs/testing.md and architecture/testing.md, and the prior audit-fix pass (#103) had mechanically changed a "breaks across httpx major versions" claim to say httpx2 instead. Verified against respx's own README (requires httpx 0.25+, no stated httpx2 support) and GitHub history: the breakage claim is real but about httpx, not httpx2. Corrected the claim and deduped, keeping the full rationale in docs/testing.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #103/#104 — resolves the two duplication findings (D1, D2) from
planning/audits/2026-07-13-docs-comments-audit.md, tracked inplanning/changes/2026-07-13.09-response-too-large-respx-compaction.md. Also fixes a factual regression surfaced while working D2.ResponseTooLargeError's behavior was spelled out near-verbatim indocs/errors.md,architecture/errors.md, andarchitecture/client.md.docs/errors.mdkeeps the full field-by-field account,architecture/client.mdkeeps the full mechanism account (both untouched beyond dedup),architecture/errors.mdis trimmed to the errors-tree-specific facts plus a cross-reference.docs/testing.mdandarchitecture/testing.md. While researching which side to keep, found that#103's mechanicalhttpx→httpx2fix had regressed a claim: it changed "respx patches private internals and breaks acrosshttpxmajor versions" into a claim abouthttpx2specifically. Verified againstrespx's own README (requireshttpx 0.25+, no statedhttpx2support) and its GitHub history (documented breakage onhttpxmajor bumps): the claim is real, but abouthttpx, nothttpx2—httpx2's own docs mentioningrespxreads as inherited copy from its stewardship transfer, not a verified compatibility claim. Corrected and deduped, keeping the full rationale indocs/testing.md.Test plan
uvx --with-requirements docs/requirements.txt mkdocs build --strict— cleanjust lint-ci— cleanjust test— 780 passed, 100% coveragejust check-planning— OK