feat(cli): link release notes after hunk update - #1022
Open
shashank-100 wants to merge 1 commit into
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
@shashank-100 is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #951.
hunk updateconfirms the version it installed but never says what changed. The changelog already publishes a stable anchor per release, so the notes are addressable.Printed after an update, when already current, and for
--check.0.0.0-unknown) rather than a URL to a 404.--checklinks the latest available version, which is what the surrounding lines describe.The URL rules live in
core/run/releaseNotes.tsrather than importing fromscripts/, since that is build tooling the CLI cannot depend on. A test reads every generated page underwebsite/src/content/docs/changelog/and asserts the builder reproduces each published URL, so the two cannot drift.Verification
bun run typecheck,bun run lint,bun run deps:checkclean.bun run test: 3927 pass, 2 fail — both pre-existing, reproduced on a clean tree at this base (install VM contracthits a macOS/var->/private/varsymlink mismatch;Jujutsu source readingpasses when not run under full-suite load). This diff touches onlyselfUpdateand the newreleaseNotesmodule.Checked the generated URLs against the live site — all 200 with the anchor present in the served HTML:
And on the compiled binary:
Verified on macOS.