refactor(ui): inline diff row dispatch - #1018
Merged
benvinegar merged 1 commit intoSep 7, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Sep 7, 2026
Contributor
Greptile SummaryThis PR simplifies diff-row rendering by moving metadata/code row dispatch directly into
Confidence Score: 5/5The PR appears safe to merge because it preserves the existing exhaustive row dispatch and child prop forwarding. No actionable failures remain; every valid row variant follows the same rendering branch with the same values as before, and the empty changeset matches repository convention. Important Files Changed
Reviews (1): Last reviewed commit: "refactor(ui): inline diff row dispatch" | Re-trigger Greptile |
benvinegar
force-pushed
the
refactor/diff-row-inline-dispatch
branch
from
September 7, 2026 12:43
a1ee26d to
2b1088e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffRowViewCodeRowViewandDiffMetaRowViewboundariesWhy
The helper had one caller and repeated the facade's complete prop list positionally. Keeping dispatch beside prop resolution makes forwarding easier to audit without changing row rendering ownership.
Stack
Merge bottom to top. This PR is based on
refactor/diff-row-default-memo; the next PR is based on this branch.Validation
Run on the stack tip:
bun run typecheckbun run testbun run test:integrationbun run test:tty-smokeAll passed. No user-visible rendering behavior changes, so no new visual evidence was captured.
This PR description was generated by Pi using gpt-5.6-sol