Fix provider message preprocessing regressions - #9840
Draft
taking-lying-flat wants to merge 1 commit into
Draft
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
taking-lying-flat
requested a deployment
to
qoder-review
August 4, 2026 00:31 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
List[int]message content out of Anthropic auto-detectionrejected_messagestorejected_imagesrejected_imagesRoot cause
#9809 added provider auto-detection that called
block.get()for every item in list-valued message content. SWIFT also supports list-valued pretokenized token IDs, so validList[int]content raisedAttributeErrorduring preprocessing.The recursive
rejected_messagespath retained only the normalized messages from its temporary result. Anthropic image extraction therefore left<image>placeholders in the rejected messages while discarding the corresponding media.Impact
Pretokenized datasets continue through
MessagesPreprocessorunchanged, and Anthropic multimodal preference rows retain their rejected images without silently overriding an explicitly supplied top-level field.Follow-up to #9809.
Validation
TestRejectedMessagesPreprocessandTestProviderMessagesPreprocesstests passedflake8passed for both changed filesisort --check-onlypassed for both changed filesyapf --diffpassed for both changed filesgit diff --checkpassed