Guard GRPO against non-finite Liger updates - #9839
Draft
taking-lying-flat wants to merge 1 commit into
Draft
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
taking-lying-flat
requested a deployment
to
qoder-review
August 3, 2026 18:42 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
liger-kernel>=0.8.0when GRPO enables the fused Liger lossRoot cause
In the affected Qwen3.5 GRPO runs, the first rollout is healthy, but the first optimizer update can produce invalid LoRA parameters with the older Liger fused PPO/GRPO backward path. The next rollout synchronizes those adapter updates to vLLM, which exposes the corruption as degenerate completions such as repeated
!tokens.Liger 0.8 rewrote this backward path to use selective log-probability computation and FP32 gradient accumulation instead of the older
torch.func.grad_and_valueimplementation. Requiring that version prevents the known unsafe combination from running silently.The finite check is a second line of defense: if any later numerical issue still corrupts LoRA parameters, synchronization now fails at the source with the affected parameter names instead of loading invalid weights into vLLM.
Addresses #9835 and is consistent with the reproduction findings in #9619.
Implementation notes
Validation
flake8,isort --check-only, andyapf --diffpassed for all changed filesgit diff --checkpassed