Fix Qwen3.5 multimodal packing kwargs compatibility - #9838
Draft
taking-lying-flat wants to merge 1 commit into
Draft
Fix Qwen3.5 multimodal packing kwargs compatibility#9838taking-lying-flat wants to merge 1 commit into
taking-lying-flat wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
taking-lying-flat
requested a deployment
to
qoder-review
August 3, 2026 18:16 — with
GitHub Actions
Waiting
taking-lying-flat
force-pushed
the
agent/fix-qwen35-causal-conv-routing
branch
from
August 3, 2026 18:21
90b6695 to
0622737
Compare
taking-lying-flat
requested a deployment
to
qoder-review
August 3, 2026 18:21 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cu_seq_lens_q,cu_seq_lens_k,max_length_q, andmax_length_k) from leaking into the vision tower>=5.2.0, matching the first stable Qwen3.5 release and the existing MoE requirementRoot cause
Transformers 5.9+ forwards the model-level packing kwargs into the Qwen3.5 vision tower. The vision attention path also supplies its own sequence-length kwargs explicitly, which raises a duplicate-keyword
TypeError. The hook strips only the four text packing keys at the vision boundary while leaving the original kwargs unchanged for the language model.The previous dense/Ovis requirement (
transformers>=5.0.0.dev) also admitted stable 5.0/5.1 releases that do not provide Qwen3.5. The corrected lower bound is5.2.0.Compatibility
Tested every published stable Transformers release in the project's supported range:
5.2.0,5.3.0,5.4.0,5.5.0,5.6.0,5.7.0,5.8.0,5.9.0,5.10.0,5.11.0,5.12.0,5.12.1,5.13.0,5.13.1,5.14.0, and5.14.1.The collision begins in 5.9.0. On 5.2-5.8 the hook remains compatible and harmless.
Local validation
git diff --checkpassed