Skip to content

enable_thinking is set to False for hybrid thinking models.#9557

Merged
Jintao-Huang merged 8 commits into
modelscope:mainfrom
Jintao-Huang:enable_thinking_false
Jun 15, 2026
Merged

enable_thinking is set to False for hybrid thinking models.#9557
Jintao-Huang merged 8 commits into
modelscope:mainfrom
Jintao-Huang:enable_thinking_false

Conversation

@Jintao-Huang

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default behavior of the enable_thinking parameter during inference. Specifically, for hybrid thinking templates (which contain a non-thinking prefix), the default value of enable_thinking is changed from True to False, while pure thinking templates continue to default to True. This change is implemented in swift/template/base.py and documented in both the Chinese and English command-line parameter guides. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Jintao-Huang Jintao-Huang merged commit 46f4df6 into modelscope:main Jun 15, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants