Bug fix in last checkpoint save. #460
Open
+695
−440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat save in same step
Contributor
Summary of ChangesHello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant improvement to the checkpointing mechanism by preventing redundant saves of various training components within a single global step. By refactoring the checkpoint managers and implementing step-based tracking for each save type, the system now avoids unnecessary I/O operations, leading to more efficient and robust training workflows. This change streamlines the checkpointing process without altering the core functionality of what is being saved. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a bug that caused repeated checkpoint saves for the same step. The refactoring introduces latest_*_save_step attributes to track saves for different components individually, which is a solid approach. The code is also made more modular by extracting saving logic into separate private methods, improving readability and maintainability. I've included a few suggestions to further enhance code clarity.
2. Add process clean up in `tearDown` for `trainer_test.py` and `synchronizer_test.py` 3. Add `ignore_errors=True` for `shutil.rmtree` 4. Rename `RayUnittestBaseAysnc` to `RayUnittestBaseAsync` 5. Bug fix in last step save 6. Apply reviews from gemini
Collaborator
Author
|
/unittest-module-trainer |
Collaborator
Author
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
latest_*_save_stepto avoid repeat save in same step, which will fix the bug where the huggingface checkpoint may not have been saved during the final training step.TestTrainerCheckpointSavetearDownfortrainer_test.pyandsynchronizer_test.pyignore_errors=Trueforshutil.rmtreeRayUnittestBaseAysnctoRayUnittestBaseAsync.Checklist
Please check the following items before code is ready to be reviewed.