Track TEN review bot permission gate#3097
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a known review gate action for a specific repository fork issue and updates the recommendation logic in scripts/collect_growth_metrics.py to return this action when a review bot check fails. It also updates the corresponding test cases. The feedback suggests simplifying the logic in recommend_integration_action by combining the check for known_review_gate_action with the default "review bot gate" return value to eliminate redundant condition checks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if known_review_gate_action and ( | ||
| "claude-review" in failed_names or "review bot" in failed_names | ||
| ): | ||
| return known_review_gate_action |
There was a problem hiding this comment.
To simplify the logic and avoid duplicate condition checks, you can combine this check with the subsequent review bot gate check.
Since suggestions are limited to modified lines, applying the suggestion below will leave the original check on lines 324-325 as redundant/dead code. Please make sure to manually delete lines 324-325 after applying this suggestion.
if "claude-review" in failed_names or "review bot" in failed_names:
return known_review_gate_action or "review bot gate"
Summary
Verification
External evidence: