Skip to content

Track TEN review bot permission gate#3097

Merged
LauraGPT merged 1 commit into
mainfrom
codex/track-ten-review-bot-gate
Jun 30, 2026
Merged

Track TEN review bot permission gate#3097
LauraGPT merged 1 commit into
mainfrom
codex/track-ten-review-bot-gate

Conversation

@LauraGPT

Copy link
Copy Markdown
Collaborator

Summary

Verification

  • python -m pytest tests/test_collect_growth_metrics.py::test_collect_integration_metrics_classifies_review_bot_failure -q
  • python -m pytest tests/test_collect_growth_metrics.py -q
  • python -m py_compile scripts/collect_growth_metrics.py && git diff --check
  • python scripts/collect_growth_metrics.py --integrations --integration-prs feat: add funasr_asr_python local FunASR (SenseVoice) ASR extension TEN-framework/ten-framework#2191 --format json | jq -r '.integrations[0] | [.pr,.checks.state,.known_review_gate_reason,.next_action] | @TSV'

External evidence:

@LauraGPT LauraGPT merged commit 9cd89b2 into main Jun 30, 2026
@LauraGPT LauraGPT deleted the codex/track-ten-review-bot-gate branch June 30, 2026 11:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a known review gate action for a specific repository fork issue and updates the recommendation logic in scripts/collect_growth_metrics.py to return this action when a review bot check fails. It also updates the corresponding test cases. The feedback suggests simplifying the logic in recommend_integration_action by combining the check for known_review_gate_action with the default "review bot gate" return value to eliminate redundant condition checks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +320 to +323
if known_review_gate_action and (
"claude-review" in failed_names or "review bot" in failed_names
):
return known_review_gate_action

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To simplify the logic and avoid duplicate condition checks, you can combine this check with the subsequent review bot gate check.

Since suggestions are limited to modified lines, applying the suggestion below will leave the original check on lines 324-325 as redundant/dead code. Please make sure to manually delete lines 324-325 after applying this suggestion.

    if "claude-review" in failed_names or "review bot" in failed_names:
        return known_review_gate_action or "review bot gate"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant