Skip to content

Fix a compatibility issue with the timestamp format for Fun-ASR-Nano-2512#2814

Open
slin000111 wants to merge 4 commits intomodelscope:mainfrom
slin000111:main
Open

Fix a compatibility issue with the timestamp format for Fun-ASR-Nano-2512#2814
slin000111 wants to merge 4 commits intomodelscope:mainfrom
slin000111:main

Conversation

@slin000111
Copy link
Contributor

  1. Fix 使用示例代码,开启vad后报错,不开启能正常运行 #2803
  2. The example tests for paraformer/seaco-paraformer/sensevoice/fun-asr-nano have passed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @slin000111, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical compatibility issue related to timestamp handling within the funasr framework, particularly affecting the Fun-ASR-Nano-2512 model. The changes ensure robust and consistent timestamp calculations by adapting to different data structures used for time representation, thereby preventing incorrect time alignments in processing results.

Highlights

  • Timestamp Compatibility Fix: Addressed a compatibility issue where timestamp formats varied, specifically for the Fun-ASR-Nano-2512 model. The change ensures that timestamps are correctly adjusted regardless of whether they are represented as a dictionary (with 'start_time' and 'end_time' keys) or as a list/tuple (with numerical indices).
  • Bug Fix Reference: This pull request resolves issue 使用示例代码,开启vad后报错,不开启能正常运行 #2803, which likely detailed the timestamp compatibility problem.
  • Test Verification: Confirmed that example tests for paraformer, seaco-paraformer, sensevoice, and fun-asr-nano models have passed, indicating the fix does not introduce regressions and works as expected.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • funasr/auto/auto_model.py
    • Modified the inference_with_vad function to conditionally adjust timestamps based on their format (dictionary or list/tuple), ensuring correct time alignment after VAD processing.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a compatibility issue with different timestamp formats by adding support for a dictionary-based format alongside the existing list-based one. The implementation is logically sound. I have one suggestion to improve the readability of the timestamp adjustment calculation.

Comment on lines +559 to +560
t["start_time"] = (t["start_time"] * 1000 + vadsegments[j][0]) / 1000
t["end_time"] = (t["end_time"] * 1000 + vadsegments[j][0]) / 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The calculation for adjusting timestamps can be simplified for better readability. Directly adding the offset in seconds is more concise and achieves the same result.

Suggested change
t["start_time"] = (t["start_time"] * 1000 + vadsegments[j][0]) / 1000
t["end_time"] = (t["end_time"] * 1000 + vadsegments[j][0]) / 1000
t["start_time"] += vadsegments[j][0] / 1000.0
t["end_time"] += vadsegments[j][0] / 1000.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

使用示例代码,开启vad后报错,不开启能正常运行

1 participant