Update package inclusion pattern in pyproject.toml#1187
Update package inclusion pattern in pyproject.toml#1187Artiprocher merged 2 commits intomodelscope:mainfrom
Conversation
Update to install all the sub-packages inside diffsynth. Otherwise, the installed packages only contain __init__.py
Summary of ChangesHello @jiaqixuac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where Python package installations were incomplete, specifically for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the pyproject.toml file to correctly include all sub-packages of the diffsynth library during installation. The change from "diffsynth" to "diffsynth*" in the include pattern is functional, but I've suggested a more precise and idiomatic pattern to prevent potential conflicts and improve clarity, following setuptools best practices.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Update package inclusion pattern in pyproject.toml
Update to install all the sub-packages inside
diffsynth. Otherwise, the installeddiffsynthpackage only contains__init__.py, but not contains other site-packages likecore,diffusion, etc.