fix: correct test error reporting, stale message, docs typos and broken anchor#223
fix: correct test error reporting, stale message, docs typos and broken anchor#223aftersnow wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several documentation and code fixes. Key changes include fixing grammatical errors in README.md and docs/config.md, correcting a markdown link anchor in docs/annotations.md, fixing a bug in schema/example_test.go where the wrong error variable was passed to t.Error, updating an internal error message in schema/validator.go, and improving struct comments in specs-go/v1/config.go. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…en anchor - schema/example_test.go: report example.Err instead of the stale outer err (fixes #210) - schema/validator.go: error message referenced renamed map validateByMediaType - docs/annotations.md: lowercase intra-doc anchor so it resolves on GitHub - docs/config.md: remove duplicated word 'value' (x2) - README.md: fix grammar (Its goal; cloud native environments) - specs-go/v1/config.go: fix ModelFS comment grammar Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Zhao Chen <winters.zc@antgroup.com>
aftersnow
force-pushed
the
aftersnow-repo-analysis-improvements
branch
from
f989070 to
4c3f9a5
Compare
2 participants
What
A batch of small, low-risk correctness and documentation fixes found during a repository review:
schema/example_test.go: reportexample.Errinstead of the stale outererrvariable, so example parsing failures surface the actual error instead of<nil>. Fixes TestValidateConfigExample silently swallows example parsing errors #210schema/validator.go: the internal error message referencedmapValidate, which no longer exists (the map is namedvalidateByMediaType)docs/annotations.md: lowercase the intra-doc anchor#file-metadata-annotation-valueso the link resolves on GitHubdocs/config.md: remove the duplicated word in "the value "other" value should be used" (bothinputTypesandoutputTypes)README.md: grammar fixes — "It's goal" → "Its goal", "in a cloud native environments" → "in cloud native environments"specs-go/v1/config.go: fix grammar in theModelFScomments ("describes a layer content addresses")Why
These are cosmetic/correctness-only changes: no behavior, schema, or API changes.
go build ./...,go vet ./..., andgo test ./...all pass.