Start replicated models based on version hash#2382
Draft
abstraktor wants to merge 2 commits intomainfrom
Draft
Conversation
Contributor
The vue-model-api had a **leaky abstraction** around role handling: 1. **INodeJS API contract** promised: "Role objects returned from `getReferenceRoles()` can be passed back unchanged" 2. **Implementation reality**: `NodeAdapterJS.getReferenceRoles()` returns `IRoleReference` objects (Kotlin), but `ReactiveINodeJS` was forced to cast them to strings to work with `MapWithRoleKey.getOrPut(roleString: String)` 3. **Consequence**: As a result, we got a TypeError when calling getReferenceTargetNode(getReferenceRoles().first)
abstraktor
force-pushed
the
feat/start-replicated-models-by-version-hash
branch
from
4e1dc75 to
ac48054
Compare
abstraktor
changed the base branch from
main
to
fix/reference-roles-in-inodejs
abstraktor
force-pushed
the
feat/start-replicated-models-by-version-hash
branch
3 times, most recently
from
edb7441 to
9ea7d6f
Compare
Contributor
JVM coverage report
|
…nHash and repositoryId
abstraktor
force-pushed
the
feat/start-replicated-models-by-version-hash
branch
from
9ea7d6f to
035cb2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes