Draft: feat(metamodel-export): serialize annotations on concept nodes into the metamodel json#1877
Draft: feat(metamodel-export): serialize annotations on concept nodes into the metamodel json#1877abstraktor wants to merge 1 commit intomainfrom
Conversation
Test Results 239 files 239 suites 51m 4s ⏱️ Results for commit cb6d8d6. ♻️ This comment has been updated with latest results. |
JVM coverage report
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt
Fixed
Show fixed
Hide fixed
metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt
Fixed
Show fixed
Hide fixed
| for (reference: SReference in node.references) { | ||
| references[reference.link.name] = reference.targetNodeReference.toString() | ||
| companion object { | ||
| fun exportNode(node: SNode): NodeData { |
Check warning
Code scanning / detekt
The function exportNode is missing documentation. Warning
abstraktor
force-pushed
the
feature/export-concept-annotations
branch
2 times, most recently
from
788c514 to
38e1ac1
Compare
| val smodelAttribute: SContainmentLink = MetaAdapterFactory.getContainmentLink( | ||
| -0x3154ae6ada15b0deL, | ||
| -0x646defc46a3573f4L, | ||
| 0x10802efe25aL, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
| -0x3154ae6ada15b0deL, | ||
| -0x646defc46a3573f4L, | ||
| 0x10802efe25aL, | ||
| 0x47bf8397520e5942L, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
|
I would prefer representing the supported annotations as separate data classes instead of exporting them as NodeData. |
…he metamodel json
abstraktor
force-pushed
the
feature/export-concept-annotations
branch
from
38e1ac1 to
cb6d8d6
Compare
| jsonFile.writeText(languageData.toJson(), StandardCharsets.UTF_8) | ||
| } | ||
|
|
||
| fun exportAnnotation(node: SNode): AnnotationData = |
Check warning
Code scanning / detekt
The function exportAnnotation is missing documentation. Warning
| ) | ||
|
|
||
| val AttributeInfoConceptDeclaration: SConcept = MetaAdapterFactory.getConcept( | ||
| -4094437568663370681, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
|
|
||
| val AttributeInfoConceptDeclaration: SConcept = MetaAdapterFactory.getConcept( | ||
| -4094437568663370681, | ||
| -8968368868337559369, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
| val AttributeInfoConceptDeclaration: SConcept = MetaAdapterFactory.getConcept( | ||
| -4094437568663370681, | ||
| -8968368868337559369, | ||
| 2992811758677295509, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
| "memberId", | ||
| ) | ||
| val attributeInfoRole: SProperty = MetaAdapterFactory.getProperty( | ||
| -4094437568663370681, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
| ) | ||
| val attributeInfoRole: SProperty = MetaAdapterFactory.getProperty( | ||
| -4094437568663370681, | ||
| -8968368868337559369, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
| val attributeInfoRole: SProperty = MetaAdapterFactory.getProperty( | ||
| -4094437568663370681, | ||
| -8968368868337559369, | ||
| 2992811758677295509, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
| -4094437568663370681, | ||
| -8968368868337559369, | ||
| 2992811758677295509, | ||
| 7588428831955550663, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
2 participants
Changes