Support of Modelica_StateGraph2 Connections.uniqueRoot#3701
Open
HansOlsson wants to merge 2 commits intomodelica:masterfrom
Open
Support of Modelica_StateGraph2 Connections.uniqueRoot#3701HansOlsson wants to merge 2 commits intomodelica:masterfrom
HansOlsson wants to merge 2 commits intomodelica:masterfrom
Conversation
Collaborator
Author
|
This is now more or less the text from Modelica_StateGraph2; except that in case someone connects two unique roots tools are not restricted to using one message in the diagnostics. (The messages will normally be the same, but given that it is even an error to connect two roots with the same message it doesn't make sense to require an additional diagnostics in case they are different.) |
HansOlsson
changed the title
Collaborator
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In progress.
The operator definitions need more work.