Repository navigation
Conversation
RFC 6750 §3.1 says a challenge for a request with no authentication information should not include an error code. requireBearerAuth now drops error and error_description when scope or resource_metadata is already present, and the Express adapter sends that same body. A rejected token still returns invalid_token, and a challenge with neither parameter keeps the error code. Fixes modelcontextprotocol#3124 Co-authored-by: Anandu Mv <Anandumv@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 1584c28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
claude
Bot
added
the
v2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3124.
Summary
requireBearerAuthanswered a request with noAuthorizationheader as401 invalid_token. RFC 6750 §3.1 says a resource server should not include an error code when the request has no authentication information.The challenge now omits
erroranderror_descriptionwhenscopeorresource_metadatais already present, and the JSON body is{}so it matches the header. The Express adapter sends that same body. A presented token that fails verification is unchanged. When neitherscopenorresource_metadatais configured, the challenge still includesinvalid_token, so it is never a bareBearer.Tests
@modelcontextprotocol/serverand@modelcontextprotocol/expressfor scope only,resource_metadataonly, both, neither, a rejected token, and a malformedAuthorizationheader.hosting:auth:missing-401andhosting:auth:query-token-ignoredexpect the credential-less challenge.pnpm lint:all,pnpm build:all, andpnpm test:allpass. The bearer-auth and bearer-auth-web examples pass on the modern and legacy HTTP legs.