Repository navigation
chore(changeset): release skipOfflineAccessConsentPrompt as a minor - #3135
felixweinberger wants to merge 1 commit into
Conversation
PR 2877 adds public API, and VERSIONING.md makes new backward-compatible features minor, so the next release is 2.5.0 rather than 2.4.1. Co-authored-by: fweinberger <fweinberger@anthropic.com>
|
| Name | Type |
|---|---|
| @modelcontextprotocol/client | Minor |
| @modelcontextprotocol/codemod | Minor |
| @modelcontextprotocol/core | Minor |
| @modelcontextprotocol/server-legacy | Minor |
| @modelcontextprotocol/server | Minor |
| @modelcontextprotocol/core-internal | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
There was a problem hiding this comment.
I reviewed this PR and found no bugs. Because the one-line change decides the next release number for the whole fixed group (2.5.0 instead of 2.4.1) and the path falls under the repo-wide CODEOWNERS rule, a maintainer's sign-off is still worthwhile.
What was reviewed:
- Bump level:
skipOfflineAccessConsentPromptis a new optional member onOAuthClientProviderand a newstartAuthorization()option inpackages/client/src/client/auth.ts, whichVERSIONING.mdclasses as a backward-compatible feature, so minor fits. - Changeset text against the code: the option is only read in the
!skipOfflineAccessConsentPrompt && scope includes offline_accessguard, so "default behavior is unchanged" holds. - Knock-on bumps:
express,fastify,honoandnodepeer on@ modelcontextprotocol/serverwithworkspace:^, and.changeset/config.jsonsetsonlyUpdatePeerDependentsWhenOutOfRange, so 2.5.0 stays in range and should not force majors there. I did not runchangeset versionmyself.
Extended reasoning...
The diff changes one line in .changeset/skip-offline-access-consent-prompt.md, moving the @ modelcontextprotocol/client bump from patch to minor; no source, test or docs files change. It touches no security-sensitive runtime surface itself, although the feature it releases is in the OAuth client flow that is already on the base branch. The bump matches VERSIONING.md and the changeset text matches the code. I deferred rather than approved because .github/CODEOWNERS assigns every path to the typescript-sdk team and because the release level for the five fixed-group packages is a maintainer decision.
Summary
Changes the changeset from #2877 from patch to minor, so the next release is 2.5.0 rather than 2.4.1. #2877 adds
skipOfflineAccessConsentPromptto the publicOAuthClientProvidertype andstartAuthorization(), andVERSIONING.mdmakes new backward-compatible features minor. #3085 added an opt-in provider member in the same way and shipped as minor.The fixed group moves together, so
server,core,server-legacyandcodemodalso go to 2.5.0.Test plan
Ran
changeset version(2.30.0, the locked version) on a copy ofmain, with the changelog generator turned off, once per bump level.core-internalgoes to 2.0.6, andexpress,fastify,honoandnodedo not move.The workspace install and test suite were not run, and this change touches no runtime code.
Generated by Claude Code