test(conformance): cover SEP-2640 skills server - #2797
Open
tobi-oye wants to merge 1 commit into
Open
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SEP-2640 (Skills extension) coverage to the TypeScript SDK's server conformance fixture, so the merged skills scenarios in modelcontextprotocol/conformance#330 run against this SDK.
The conformance server now:
io.modelcontextprotocol/skillsextension withdirectoryRead: true.SKILL.mdplus one supporting file in a subdirectory, with real SHA-256 digests and byte sizes.skills/list,skills/get, andresources/directory/readthrough the SDK's typed custom request-handler API.ttlMsandcacheScopefor modern protocol requests (2026-07-28 and later), and omits them on earlier revisions.-32602 Invalid paramsfor unknown skill URIs and for non-directory resource requests.Scope
This is a conformance fixture that demonstrates the existing public SDK APIs. It does not add a new first-class
registerSkillAPI, and it does not change any SDK implementation code. Skill files are registered as ordinary resources viaregisterResource, and the three SEP-2640 methods are wired withserver.setRequestHandler, using the typed{ params, result }schema form the SDK already exposes.All changes are confined to
test/conformance/:test/conformance/src/skills.tstest/conformance/src/everythingServer.tsTest results
The legacy run confirms the cache attributes are correctly version-gated: on the 2025-11-25 lifecycle the two
ttlMs/cacheScopechecks skip rather than fail.Terminal output
🤖 Generated with Claude Code