fix(client): clear resumption state on empty SSE event IDs - #2771
Open
znnnnnnn-wil wants to merge 1 commit into
Open
fix(client): clear resumption state on empty SSE event IDs#2771znnnnnnn-wil wants to merge 1 commit into
znnnnnnn-wil wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: bf24200 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
@felixweinberger Hey Felix, would you mind taking a look at this when you get a chance? It fixes the empty SSE id: resumption case from #2769. All checks are green. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2769.
An explicitly empty SSE
id:is a last-event-ID reset, not an absent ID. The truthyevent.idguard currently ignores that reset and reuses the previous token on reconnect.onresumptiontoken('')when the ID is explicitly empty.Last-Event-ID.The tests exercise the real SSE parser through the transport with mocked fetch and fake timers: GET header/callback behavior for empty versus absent IDs, and POST stream termination with an empty ID both with and without an earlier non-empty ID. The original empty-ID regression failed before the fix.
This follows the WHATWG SSE empty-ID semantics. ID-only blocks without a dispatched data event and retry-accounting changes in #2684 are outside this PR's scope.
Verification
On Windows, Node.js 22.19.0:
--end-of-line autobecause the checkout uses Windows line endings.git diff --check: passed.AI assistance was used for investigation, implementation, tests, and this PR description.