fix(stdio): release ReadBuffer backing after final byte#2540
Open
piyushbag wants to merge 1 commit into
Open
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Clear _buffer when readMessage consumes through the trailing newline so idle stdio transports do not retain the previous allocation and the next append can assign directly instead of Buffer.concat.
piyushbag
force-pushed
the
fix/readbuffer-clear-consumed-buffer
branch
from
July 23, 2026 16:18
8f6051f to
8a36bde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ReadBuffer.readMessage()leaves an emptyBuffersubarray after consuming a complete line. The subarray still references the accumulated backing allocation, so idle stdio transports retain memory longer than necessary and the next append always copies viaBuffer.concat()even when no bytes remain buffered.Approach
When the remainder after a newline is empty, set
_buffertoundefinedinstead of an empty subarray. Non-empty remainders are unchanged.Test plan
Buffer.concatis not called on the next append after a fully consumed messagepnpm --filter @modelcontextprotocol/core-internal test(1294 passed)Fixes #2536