feat(compat): IsomorphicHeaders/FetchLike/RequestInfo deprecated type aliases#1905
Draft
felixweinberger wants to merge 1 commit intomainfrom
Draft
feat(compat): IsomorphicHeaders/FetchLike/RequestInfo deprecated type aliases#1905felixweinberger wants to merge 1 commit intomainfrom
felixweinberger wants to merge 1 commit intomainfrom
Conversation
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
…rphicHeaders, RequestInfo) Adds @deprecated type aliases to core/public for smoother v1→v2 migration: - ResourceTemplate → ResourceTemplateType (the spec-derived data type) - IsomorphicHeaders → Headers (standard web type) - RequestInfo → Request (standard web type) FetchLike retains its v1 name and was already re-exported. Server's ResourceTemplate helper class intentionally shadows the deprecated type alias via named-export-wins-over-export-star ES module semantics; the import/export lint rule is suppressed at those two sites with an explanatory comment.
felixweinberger
force-pushed
the
fweinberger/v2-bc-type-aliases
branch
from
e316e7d to
b49482b
Compare
🦋 Changeset detectedLatest commit: b49482b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v2 backwards-compatibility series — see reviewer guide.
v2 moved to Web-standard
Headers/Request. This re-exports the v1 type names as@deprecatedaliases.Motivation and Context
v2 moved to Web-standard
Headers/Request. This re-exports the v1 type names as@deprecatedaliases.v1 vs v2 pattern & evidence
v1 pattern:
`const h: IsomorphicHeaders = req.headers`v2-native:
`const h: Headers = req.headers`Evidence: Low volume but zero-cost to shim.
How Has This Been Tested?
v2-bc-integrationvalidation branchpnpm typecheck:all && pnpm lint:all && pnpm test:allgreenBreaking Changes
None — additive
@deprecatedshim. Removed in v3.Types of changes
Checklist
Additional context
Stacks on: none