feat(compat): McpError/ErrorCode/JSONRPCError/StreamableHTTPError + OAuth subclass aliases#1903
Draft
felixweinberger wants to merge 2 commits intomainfrom
Draft
feat(compat): McpError/ErrorCode/JSONRPCError/StreamableHTTPError + OAuth subclass aliases#1903felixweinberger wants to merge 2 commits intomainfrom
felixweinberger wants to merge 2 commits intomainfrom
Conversation
…tter, and legacy OAuth error subclasses v1-compat shims (all @deprecated, removed in v3): - McpError -> ProtocolError, ErrorCode -> ProtocolErrorCode (re-export aliases) - OAuthError.errorCode getter -> .code (warns once) - 17 OAuth error subclasses (InvalidTokenError etc.) + CustomOAuthError as thin wrappers around OAuthError(OAuthErrorCode.X, ...), preserving v1 constructor signature, static errorCode, and instanceof OAuthError InvalidRequestError is defined in oauthErrorsCompat.ts but intentionally not re-exported from core/public to avoid colliding with the JSON-RPC InvalidRequestError interface from types.ts; the sdk meta-package server/auth/errors.js subpath will surface it.
🦋 Changeset detectedLatest commit: 68afee0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v2 backwards-compatibility series — see reviewer guide.
v2 split
McpErrorintoProtocolError/SdkErrorand consolidated 17 OAuth error classes intoOAuthError+OAuthErrorCode. This restores the v1 names as@deprecatedaliases/subclasses.Motivation and Context
v2 split
McpErrorintoProtocolError/SdkErrorand consolidated 17 OAuth error classes intoOAuthError+OAuthErrorCode. This restores the v1 names as@deprecatedaliases/subclasses.v1 vs v2 pattern & evidence
v1 pattern:
v2-native:
Evidence: GitHub code search: ~1,540 files reference
McpError/ErrorCode.ErrorCode.ConnectionClosed/RequestTimeoutshimmed toSdkErrorCodevalues so comparisons work (string-vs-number assignment toerror.code: numberis irreducible — 1-line consumer fix).How Has This Been Tested?
v2-bc-integrationvalidation branchpnpm typecheck:all && pnpm lint:all && pnpm test:allgreenBreaking Changes
None — additive
@deprecatedshim. Removed in v3.Types of changes
Checklist
Additional context
Stacks on: C1