fix(core): move @cfworker/json-schema out of main barrel into /validators/cf-worker subpath#1897
Draft
felixweinberger wants to merge 1 commit intomainfrom
Draft
fix(core): move @cfworker/json-schema out of main barrel into /validators/cf-worker subpath#1897felixweinberger wants to merge 1 commit intomainfrom
felixweinberger wants to merge 1 commit intomainfrom
Conversation
CfWorkerJsonSchemaValidator was re-exported from the core internal barrel, pulling the optional-peer @cfworker/json-schema static import into every Node consumer's bundle. Move it to a dedicated core/validators/cfWorker subpath; the workerd/browser _shims and the public /validators/cf-worker subpath import from there instead. Main index.mjs no longer references the package.
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v2 backwards-compatibility series — see reviewer guide.
The CF-Worker validator was statically imported into the main barrel, crashing Node/browser/bun consumers without the optional
@cfworker/json-schemadep. This moves it to a dedicated subpath so tsdown code-splits it.Motivation and Context
The CF-Worker validator was statically imported into the main barrel, crashing Node/browser/bun consumers without the optional
@cfworker/json-schemadep. This moves it to a dedicated subpath so tsdown code-splits it.v1 vs v2 pattern & evidence
v1 pattern:
v2-native:
SameEvidence: Verified
packages/{server,client}/dist/index.mjshave 0@cfworker/json-schemareferences after this change.How Has This Been Tested?
v2-bc-integrationvalidation branchpnpm typecheck:all && pnpm lint:all && pnpm test:allgreenBreaking Changes
None — additive
@deprecatedshim. Removed in v3.Types of changes
Checklist
Additional context
Stacks on: none