fix(core): fall back to z.toJSONSchema for zod schemas without ~standard.jsonSchema#1895
Draft
felixweinberger wants to merge 1 commit intomainfrom
Draft
fix(core): fall back to z.toJSONSchema for zod schemas without ~standard.jsonSchema#1895felixweinberger wants to merge 1 commit intomainfrom
felixweinberger wants to merge 1 commit intomainfrom
Conversation
…ard.jsonSchema Schemas from zod <4.2.0 implement StandardSchemaV1 but not StandardJSONSchemaV1, so standardSchemaToJsonSchema crashed at `undefined[io]` on tools/list. Detect `vendor: 'zod'` without `jsonSchema` and fall back to the bundled z.toJSONSchema() with a one-time warning. Non-zod libraries without jsonSchema get a clear error pointing at fromJsonSchema(). Bumps catalog zod to ^4.2.0.
🦋 Changeset detectedLatest commit: b80761d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v2 backwards-compatibility series — see reviewer guide.
Servers on zod 3.x or 4.0-4.1 crash at runtime on
tools/listbecause~standard.jsonSchemadoesn't exist. This adds a fallback toz.toJSONSchema()for zod-vendor schemas and bumps the catalog tozod: ^4.2.0.Motivation and Context
Servers on zod 3.x or 4.0-4.1 crash at runtime on
tools/listbecause~standard.jsonSchemadoesn't exist. This adds a fallback toz.toJSONSchema()for zod-vendor schemas and bumps the catalog tozod: ^4.2.0.v1 vs v2 pattern & evidence
v1 pattern:
v2-native:
Evidence: Passes typecheck but crashes at runtime — found via real-repo migration testing. Affects any server whose zod doesn't expose
~standard.jsonSchema.How Has This Been Tested?
v2-bc-integrationvalidation branchpnpm typecheck:all && pnpm lint:all && pnpm test:allgreenBreaking Changes
None — additive
@deprecatedshim. Removed in v3.Types of changes
Checklist
Additional context
Stacks on: none