feat(core): restore v1 Zod-schema overloads on setRequestHandler/setNotificationHandler/request#1891
Draft
felixweinberger wants to merge 1 commit intomainfrom
Draft
feat(core): restore v1 Zod-schema overloads on setRequestHandler/setNotificationHandler/request#1891felixweinberger wants to merge 1 commit intomainfrom
felixweinberger wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 0daaa15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This was referenced Apr 15, 2026
felixweinberger
force-pushed
the
fweinberger/protocol-concrete
branch
from
db49955 to
070a9cd
Compare
felixweinberger
changed the title
felixweinberger
force-pushed
the
fweinberger/protocol-concrete
branch
from
070a9cd to
54c7b21
Compare
5 tasks
felixweinberger
force-pushed
the
fweinberger/protocol-concrete
branch
3 times, most recently
from
31f4544 to
fec9cce
Compare
felixweinberger
changed the title
felixweinberger
force-pushed
the
fweinberger/protocol-concrete
branch
7 times, most recently
from
f573eb9 to
f20ca3b
Compare
felixweinberger
changed the title
…otificationHandler/request Adds to Protocol (inherited by Client/Server): - setRequestHandler/setNotificationHandler(ZodSchema, handler) — the v1 form, first-class - request(req, resultSchema, opts?) — the v1 explicit-schema form, first-class - callTool(params, resultSchema?, opts?) — accepts the v1 schema arg (ignored) for source compat - removeRequestHandler/removeNotificationHandler/assertCanSetRequestHandler accept any method string Custom (non-spec) methods work via the Zod-schema form, same as v1. schema.ts/standardSchema.ts unchanged from main.
felixweinberger
force-pushed
the
fweinberger/protocol-concrete
branch
from
f20ca3b to
0daaa15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v2 BC series — see reviewer guide.
Restores the v1 calling forms on
Protocol(inherited byClient/Server) so v1 code keeps working unchanged:setRequestHandler(ZodSchema, handler)/setNotificationHandler(ZodSchema, handler)— method name read from the schema'smethodliteralrequest(req, resultSchema, options?)— explicit-result-schema form, plus method-keyed return type for spec methodscallTool(params, resultSchema?, options?)— accepts the v1 schema arg (ignored) for source compatremoveRequestHandler/removeNotificationHandler/assertCanSetRequestHandleraccept any method stringCustom (non-spec) methods work via the Zod-schema form, same as v1.
schema.ts/standardSchema.tsare unchanged from main.The 3-arg validator-agnostic form is split out as #1916. Exporting
Protocol+ProtocolSpecis #1917.Motivation and Context
v1 → v2 backwards compatibility. The largest single source of v2 typecheck breaks across consumer audits was
setRequestHandlerno longer accepting the Zod-schema form; this restores it as a first-class overload.How Has This Been Tested?
packages/core/test/shared/customMethods.test.ts— Zod-schema round-trip, invalid-params rejection,removeRequestHandler('any/string'), two-arg spec form,notification()mock-assignability.Breaking Changes
None — additive.
Types of changes
Additional context
#1916 and #1917 stack on this.