fix: resolve TypeDoc warnings from directory-pointing relative links#1546
Merged
jonathanhefner merged 2 commits intomodelcontextprotocol:mainfrom Feb 17, 2026
Merged
Conversation
Replace relative markdown links that point to directories with absolute
GitHub URLs. TypeDoc cannot copy directories to the output, so these
produced warnings that failed the build under `treatWarningsAsErrors`.
- README.md: `examples/` and `packages/middleware/` links
- packages/middleware/{express,hono,node}/README.md: `../../server/`
links
Also drop `--emit none` from `docs:check`. TypeDoc only validates
relative-link targets during the render phase (in
AssetsPlugin.onRenderEnd), so `--emit none` silently skips these checks
and `docs:check` passes even when `docs` would fail. Until this is fixed
upstream, a full build is needed for `docs:check` to be a reliable CI
gate.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
felixweinberger
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace relative markdown links that point to directories with absolute GitHub URLs. TypeDoc cannot copy directories to the output, so these produced warnings that failed the build under
treatWarningsAsErrors.examples/andpackages/middleware/links../../server/linksAlso drop
--emit nonefromdocs:check. TypeDoc only validates relative-link targets during the render phase (inAssetsPlugin.onRenderEnd), so
--emit nonesilently skips these checks anddocs:checkpasses even whendocswould fail. Until this is fixed upstream, a full build is needed fordocs:checkto be a reliable CI gate.