Skip to content

Fix socket leak (CLOSE_WAIT) in NetworkTransport when reconnection is disabled #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skirrellyjones wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Fix socket leak (CLOSE_WAIT) in NetworkTransport when reconnection is disabled #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/MCP/Base/Transports/NetworkTransport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,8 @@ import Logging
break
} else {
// We're not reconnecting, finish the message stream with error
// and release the underlying socket so it doesn't leak in CLOSE_WAIT.
connection.cancel()
messageContinuation.finish(
throwing: MCPError.transportError(error))
break
Expand Down Expand Up @@ -728,6 +730,9 @@ import Logging

break
} else {
// Not reconnecting: release the underlying socket so it doesn't
// leak in CLOSE_WAIT (e.g. when the peer closes gracefully).
connection.cancel()
messageContinuation.finish(throwing: error)
}
}
Expand Down