feat: intermediate updates to newest protocol #179
+1,949
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for newest protocol version
… latest protocol version
flippinjoe
reviewed
Jan 20, 2026
| public func header(_ name: String) -> String? { | ||
| let lowercased = name.lowercased() | ||
| for (key, value) in headers { | ||
| if key.lowercased() == lowercased { |
There was a problem hiding this comment.
Question about this one. The HTTP rfc allows for multiple headers of the same name with diff values. I've seem some frameworks handle this by returning arrays of values rather than returning the first matching one. I doubt this will ever be an issue with this sdk, but wanted to call it out in case there's potential use cases that others might have in mind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has changes related to the Tool and Resources that are taken from this closed PR: #175
Motivation and Context
The idea is to make several smaller PRs compared to one huge. In this case we can iterate with maintenance more carefully.
How Has This Been Tested?
In this particular PR there's no unit tests, since the functionality is not yet completed. We have to update Server and Client respectively to these changes.
Breaking Changes
This is a wip PR, it is not designed to be published to end users
Types of changes
Checklist
Additional context