Repository navigation
Conversation
|
Friendly ping for triage. This fixes the documented The change is limited to the Dockerfile, the documented command was verified before/after, and CI is green. Happy to add a regression test or adjust the approach if maintainers prefer. |
|
63580f4 to
d74f9a0
Compare
Exec-form ENTRYPOINT does not invoke a shell, so
"${LOCAL_TIMEZONE}" was never expanded — it reached
mcp-server-time as the literal string "${LOCAL_TIMEZONE}"
on every run, regardless of what -e LOCAL_TIMEZONE was set to.
That string is truthy, so get_local_tz() always took the
override branch and called ZoneInfo("${LOCAL_TIMEZONE}"),
which raises ZoneInfoNotFoundError. The container exits 1
on startup every time, whether or not the caller sets the
variable — the feature added in modelcontextprotocol#640 has never worked.
Verified against the published Dockerfile:
# before, docker run --rm -e LOCAL_TIMEZONE=Europe/Paris mcp/time
zoneinfo._common.ZoneInfoNotFoundError: 'No time zone found
with key ${LOCAL_TIMEZONE}'
exit 1
# after, identical command
exit 0
Switched to shell-form ENTRYPOINT with `exec` so the variable
expands while mcp-server-time still replaces the shell as PID 1
(signals like SIGTERM still reach it directly, matching the
exec-form behavior everywhere else in this Dockerfile).
Signed-off-by: ks72 <20420826+ks72@users.noreply.github.com>
d74f9a0 to
024c9e8
Compare
cliffhall
added
the
closed-superseded-v2
|
Thank you for this pull request, and apologies for the long wait for a response. Since it was opened, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2, so this diff no longer applies to the code as it stands. This repository also now accepts issues, not pull requests, from anyone but its maintainers: design and implementation are done by the maintainers through a prompt-driven workflow, so outside PRs are closed rather than reviewed. The policy is in This is not a judgment on the change or on you. The problem it addresses still applies to v2 and is tracked in #5182, which links back to this PR as a prototype and credits you. Please add anything further there. This is part of the backlog triage in #4875. |
2 participants
Server: time
Change: Docker startup / LOCAL_TIMEZONE configuration
Type: Bug fix
Breaking change: None
Reproduction: documented Docker command currently exits 1
Verification: same command starts successfully after patch