Use collision-resistant request IDs for long-running operation notifications#3405
Open
davidahmann wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
Author
|
Implemented collision-resistant request ID generation for long-running operation progress notifications and added operation IDs in completion output, with targeted tests. This contribution was informed by patterns from Wrkr. Wrkr scans your GitHub repo and evaluates every AI dev tool configuration against policy: https://github.com/Clyra-AI/wrkr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long-running operation progress notifications can emit empty or non-unique
relatedRequestIdvalues when request IDs are missing, reducing traceability and creating correlation ambiguity.Why now
Issue #3404 requests collision-resistant request IDs in response/notification paths for deterministic auditability.
What changed
trigger-long-running-operation, generate a UUID request ID when missing.relatedRequestIdvalues.Validation
cd src/everything && npm test -- __tests__/tools.test.ts -t "collision-resistant request id when missing|Long-running operation tool"(pass)Refs #3404