Skip to content

readme-pr-check cannot fire on ADDITIONAL.md, so fourteen pull requests sit with no answer #4850

Closed as not planned

Description

@chrikrah

ADDITIONAL.md receives pull requests that no guard can answer, and fourteen of them are queued with zero comments between them.

.github/workflows/readme-pr-check.yml posts the "we are no longer accepting PRs to add new servers" comment and applies the readme: pending label. Two independent things stop it firing on an ADDITIONAL.md pull request:

on:
  pull_request_target:
    paths: ['README.md']

and then, inside the job:

if (files.length !== 1 || files[0].filename !== 'README.md') return;

The trigger filter never matches. The body would return early even if it did.

Measured on 2026-09-26. Fourteen open pull requests touch ADDITIONAL.md: #4836, #4818, #4802, #4779, #4778, #4766, #4751, #4743, #4727, #4699, #4675, #4671, #4664, #4646. All fourteen have zero comments.

Against that, exactly one merged pull request has ever touched the file:

merged PRs touching ADDITIONAL.md: 1
  #4255  2026-05-30T16:44:48Z  Move a list of frameworks and resources to a separate md file

That is #4255, which created the file.

The mismatch matters because ADDITIONAL.md is where a contributor lands after reading that the README is closed. CONTRIBUTING.md says "We don't accept: New server implementations". The pull request template says "We are no longer accepting PRs to add servers to the README". CLAUDE.md says "Not accepted: New server implementations …, README server listing changes". None of that reaches somebody who opens a pull request against the other file, because the one mechanism that says it in the thread covers README.md only.

Two of the fourteen add servers rather than frameworks or resources, and ADDITIONAL.md does not cover servers. Line 3 describes "a curated collection of community-built frameworks and resources that simplify building MCP servers and clients", and its only top-level sections are ## 📚 Frameworks and ## 📚 Resources. The ### For servers heading under Frameworks means frameworks for building servers.

Two ways to close it, and the choice is a maintainer decision rather than a technical one.

Add ADDITIONAL.md to the trigger and relax the filename check, so the same comment and label reach these pull requests. The wording needs a second branch, because the answer for ADDITIONAL.md concerns scope rather than the README being closed.

Or state the inclusion rules in ADDITIONAL.md itself. It carries none today, so a contributor cannot know that a server entry does not belong there until after opening the pull request.

I have no preference between them and no standing to pick. The fourteen-with-zero-comments number is the part worth acting on.

Activity

  1. chrikrah commented on Oct 12, 2026

    @chrikrah
    Author

    ad334f9 fixes the trigger half: it retired readme-pr-check.yml, and docs/contribution-model.md now treats a PR that adds "a server entry" to ADDITIONAL.md as a listing, closed with the Registry comment.

    The contributors' half isn't fixed yet. Eleven of the fourteen PRs are still open with no maintainer reply, and most add a framework or resource. Those pre-classify as listing? but have no class or answer of their own, and the Registry comment asks a framework author for a server they don't have. I'd add a Resources row with a one-line answer.

    @cliffhall, does the next triage sweep cover those eleven? I'll leave this open until it runs.

  2. cliffhall commented on Oct 19, 2026

    @cliffhall
    Member

    Closing: superseded by the v2 release.

    Thank you for reporting this, and apologies for the long wait for a response.

    Since this was filed, the reference servers have been rebuilt for the 2026-07-28 MCP specification (#4857) and released as v2 (2.0.0 on npm for the TypeScript servers, 2026.10.19 on PyPI for the Python servers). Each server now runs on v2 of its SDK, and the behavior described here has either been fixed or no longer exists in the same form. readme-pr-check.yml has been retired, and the contribution model now classifies and closes outside listing PRs, including those against ADDITIONAL.md.

    This is not a judgment on whether the problem was real; it's a consequence of the code it describes having been replaced. This is happening as part of the backlog triage in #4875.

    If this still happens on the v2 release, we'd genuinely like to know. Please open a fresh issue with the version you're running and steps to reproduce, and we'll look at it. Note that this repository accepts contributions as issues rather than pull requests; see CONTRIBUTING.md.

    Thanks for taking the time to report it.

  3. added
    closed-superseded-v2Closed: fixed or made obsolete by the v2 / 2026-07-28 refactor (#4875)
    on Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    closed-superseded-v2Closed: fixed or made obsolete by the v2 / 2026-07-28 refactor (#4875)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions