Repository navigation
fix(model): don't treat _meta alone as a CallToolResult - #1405
Open
howardjohn wants to merge 1 commit into
Open
howardjohn wants to merge 1 commit into
howardjohn wants to merge 1 commit into
Conversation
Any result type may carry `_meta`, so its presence says nothing about a
result being a tool call. Counting it as a known CallToolResult field let
CallToolResult shadow CustomResult in the untagged ServerResult union: a
custom result such as SEP-2640 `skills/list` with a top-level `_meta`
parsed as an empty CallToolResult and its payload was dropped.
Only `content`, `structuredContent`, and `isError` now satisfy the guard.
Like `{}`, a bare `{"_meta": {...}}` is no longer a CallToolResult; it
falls through to CustomResult.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
T-test
Contributor
|
@gocamille is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There is existing logic to avoid
CallToolResultfrom shadowingCustomResult. However, since any type can hold_metathis doesn't really work.In real world I am trying to use the skills extension deserialized into
CustomResult. When_metais present this fails.How Has This Been Tested?
Manually tested end to end + added/updated unit tests
Breaking Changes
No
Types of changes
Checklist
Additional context