fix: accept namespaced discovery server information#1044
Draft
tsarlandie-oai wants to merge 1 commit into
Draft
Conversation
tsarlandie-oai
force-pushed
the
codex/rmcp-1039-discovery-server-info
branch
from
July 25, 2026 00:47
2ef853e to
a08dd9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_meta["io.modelcontextprotocol/serverInfo"]keyserverInfoduring deserialization, then normalize it to canonical metadataServerPeerInfo, whereserver_infois optional across discovery and legacy initializationWhy
The discovery schema carries server implementation identity as optional result metadata. Requiring a top-level
serverInfomade conforming anonymous responses fail and made the client peer-info type unable to represent discovery accurately.The compatibility decoder keeps accepting the earlier top-level shape, while serialization now emits only the canonical metadata representation.
Compatibility
This changes
RoleClient::PeerInfofromServerInfotoServerPeerInfo. Legacy initialization converts losslessly and always suppliesSome(server_info); discovery clients must handle an absent identity.Validation
cargo +1.95.0 clippy -p rmcp --all-features --all-targets -- -D warningsFixes #1039