Handle BrokenResourceError in stdio client shutdown path#2143
Open
aframedelta wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Handle BrokenResourceError in stdio client shutdown path#2143aframedelta wants to merge 1 commit intomodelcontextprotocol:mainfrom
aframedelta wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyio.BrokenResourceErrorin stdio client reader/writer loopsWhy
Related to #1564.
When the subprocess stdio closes abruptly during client initialization,
BrokenResourceErrormay escape from stream tasks and surface as an unhelpful TaskGroup failure instead of a clean MCP connection-closed path.Changes
anyio.BrokenResourceErroralongsideClosedResourceErrorin:stdout_readerstdin_writertest_stdio_client_exits_immediately_surfaces_connection_closedValidation
. .venv/bin/activate && pytest tests/client/test_stdio.py -q -k "bad_path or exits_immediately or nonexistent_command"