Fix stdio_server from closing process stdio handles#2142
Open
aframedelta wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix stdio_server from closing process stdio handles#2142aframedelta wants to merge 1 commit intomodelcontextprotocol:mainfrom
aframedelta wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stdio_server()from closing underlying process stdio handlesWhy
Closes #1933.
stdio_server()wrapssys.stdin.buffer/sys.stdout.bufferin aTextIOWrapper. When the async wrapper is closed, the underlying process stdio can be closed too, causing subsequentprint()calls to fail withValueError: I/O operation on closed file.Changes
_NonClosingTextIOWrapperinmcp.server.stdiotest_stdio_server_does_not_close_process_stdioregression testValidation
. .venv/bin/activate && pytest tests/server/test_stdio.py -q