-
Notifications
You must be signed in to change notification settings - Fork 3.1k
chore: update author metadata to LF Projects #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
| description = "Model Context Protocol SDK" | ||
| readme = "README.md" | ||
| requires-python = ">=3.10" | ||
| authors = [{ name = "Anthropic, PBC." }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, Anthropic did authored... 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha true... is it normal to keep previous authors as well in something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to claude it's not haha, so gonna merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are asking... I'm not sure how I feel about removing a maintainer from the maintainer list (Justin). It feels like he is just forgotten from the project.
Haha true... is it normal to keep previous authors as well in something like this?
You can... I don't think there are strict rules, but I don't think MCP org is the author of this project, it's Anthropic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MCP may have ownership, but author doesn't change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are asking... I'm not sure how I feel about removing a maintainer from the maintainer list (Justin). It feels like he is just forgotten from the project
Yea definitely not wanting to remove credit from someone at all.
I was talking to @dsp-ant about it and the thinking the list should mainly contain active maintainers since it has contact details. But I'm not super fussed either way.
Justin is still kept as lead maintainer here https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/MAINTAINERS.md, although that's ofc not in this repo.
|
Instead of author on the package metadata, what needs to be changed is this: https://github.com/modelcontextprotocol/python-sdk/blob/main/LICENSE |
|
...and by change, I don't mean replace Anthropic by MCP org, but adding a new copyright line. |
Update
authorsacross all pyproject.toml files toModel Context Protocol a Series of LF Projects, LLC., matching the TypeScript SDK. Also removes stalemaintainersfrom example pyproject.toml files.