fix: handle_sse_response causing dangling client's read_stream - #1812
fix: handle_sse_response causing dangling client's read_stream #1812ivanbelenky wants to merge 2 commits into
handle_sse_response causing dangling client's read_stream #1812Conversation
handle_sse_response causing dangling client's read_stream
|
Hey @ivanbelenky — thanks for identifying this root cause, your analysis was spot on. PR #2122 covers the same fix (sending a JSONRPCError when the SSE stream ends without a response) and also addresses the infinite reconnection loop in |
Thanks @heyhayes, based on the non immediate action over this issue + PR by maintainers, I just used my fork and stopped work. Closing this as soon as any of the 2 gets merged. |
|
Thanks for the PR. This has since landed via #3047. Closing this as part of a wider backlog cleanup following the v2 launch. If it's still relevant, feel free to reopen. |
Notifying session layer on transport error. Sending the error to the client's
read_stream_writer.Motivation and Context
Indefinitely hang described on issue #1811
How Has This Been Tested?
Running suite of tests locally as per contribution guidelines.
Breaking Changes
Types of changes
Checklist
Additional context