[Server] Answer a JSON POST with only its own responses - #508
Open
vbcherepanov wants to merge 1 commit into
Open
[Server] Answer a JSON POST with only its own responses#508vbcherepanov wants to merge 1 commit into
vbcherepanov wants to merge 1 commit into
Conversation
vbcherepanov
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
September 14, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467.
With PHP-FPM, requests of the same session run in parallel and put their responses into the same session queue.
createJsonResponse()took the whole queue, so one request got all responses as a JSON array and the others got202with nothing.Now the transport collects the ids from its own POST body and takes only those responses. The rest stays in the queue. Batches are still answered with an array, single messages with one object, and an invalid message without a usable id still gets its error.
Protocol::consumeOutgoingMessages()gets the ids as an optional second argument. Without it nothing changes, so the SSE path andStdioTransportwork as before.The reproducer is
testConcurrentPostsSharingASessionEachReceiveTheirOwnResponse: the second POST is handled completely between the first one queueing its response and reading the queue. It fails onmain.Not part of this PR: