Skip to content

ci: replace sleep with compose --wait + nginx healthcheck #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chr-hertel wants to merge 2 commits into from
+12 −2
Closed

ci: replace sleep with compose --wait + nginx healthcheck #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bedee3
ci: replace sleep with compose --wait + nginx healthcheck
chr-hertel May 12, 2026
afa1521
ci: serve /healthz over IPv4 for nginx healthcheck
chr-hertel May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ jobs:
run: |
mkdir -p tests/Conformance/sessions tests/Conformance/logs
chmod -R 777 tests/Conformance/sessions tests/Conformance/logs
docker compose -f tests/Conformance/Fixtures/docker-compose.yml up -d
sleep 5
docker compose -f tests/Conformance/Fixtures/docker-compose.yml up -d --wait

- name: Run conformance tests
working-directory: ./tests/Conformance
Expand Down
6 changes: 6 additions & 0 deletions tests/Conformance/Fixtures/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ services:
- php-fpm
networks:
- mcp-net
healthcheck:
test: ["CMD", "wget", "-q", "-O-", "http://127.0.0.1/healthz"]
interval: 2s
timeout: 2s
retries: 10
start_period: 2s

php-fpm:
image: php:8.4-fpm-alpine
Expand Down
5 changes: 5 additions & 0 deletions tests/Conformance/Fixtures/nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ server {
server_name localhost;
root /app;

location = /healthz {
access_log off;
return 200 "ok\n";
}

location / {
try_files $uri /tests/Conformance/server.php$is_args$args;
}
Expand Down